Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Cloudflare Static Assets reference to serveStatic deprecation notice #3705

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ambergristle
Copy link
Contributor

Cloudflare Static Assets is now in open beta, promoted as a solution for SSR apps: https://blog.cloudflare.com/builder-day-2024-announcements/#static-asset-hosting

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Cloudflare Static Assets is now in open beta, promoted as a solution for SSR apps
@yusukebe
Copy link
Member

Hi @ambergristle

Good catch up! Looks good. Can you run the following command to format the code to pass the CI?

bun run format:fix && bun run lint:fix

@ambergristle
Copy link
Contributor Author

Can you run the following command to format the code to pass the CI?

Done! Thanks for your patience

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (190e122) to head (ce566f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3705   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         159      159           
  Lines       10158    10158           
  Branches     2855     2868   +13     
=======================================
  Hits         9315     9315           
  Misses        842      842           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Dec 3, 2024

@ambergristle

Thanks! Merging.

@yusukebe yusukebe merged commit 80c7e22 into honojs:main Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants